Skip to content

Conversation

tiny-ben-tran
Copy link
Collaborator

Related ticket: TINY-11906

Description of changes:

  • Re-mapped disabled prop to the editor's disabled option
  • Added readonly prop that maps to the editor's readonly option
  • Added a storybook case for disabled and readonly

@tiny-ben-tran tiny-ben-tran requested a review from a team as a code owner May 6, 2025 05:40
@tiny-ben-tran tiny-ben-tran requested review from spocke, TheSpyder, ltrouton, a team and tiny-james and removed request for a team May 6, 2025 05:40
@tiny-ben-tran tiny-ben-tran merged commit 8ceeac1 into main May 18, 2025
5 checks passed
@tiny-ben-tran tiny-ben-tran deleted the feature/TINY-11906 branch May 18, 2025 23:17
@mrlika
Copy link

mrlika commented May 29, 2025

import { TinyVer } from '@tinymce/miniature';

This line makes @tinymce/miniature not a dev dependency anymore:

"@tinymce/miniature": "^6.0.0",

It breaks CI builds that usually don't install dev dependencies:

 [vite]: Rollup failed to resolve import "@tinymce/miniature" from "/.../app/node_modules/@tinymce/tinymce-react/lib/es2015/main/ts/Utils.js".

@tiny-ben-tran
Copy link
Collaborator Author

import { TinyVer } from '@tinymce/miniature';

This line makes @tinymce/miniature not a dev dependency anymore:

"@tinymce/miniature": "^6.0.0",

It breaks CI builds that usually don't install dev dependencies:

 [vite]: Rollup failed to resolve import "@tinymce/miniature" from "/.../app/node_modules/@tinymce/tinymce-react/lib/es2015/main/ts/Utils.js".

@mrlika It is noted. I will resolve this issue ASAP. Thank you.

mgrunberg added a commit to mgrunberg/tinymce-react that referenced this pull request May 29, 2025
tinymce#588 added an import from
@tinymce/miniature code in src/main/ts/Utils.ts.
mgrunberg added a commit to mgrunberg/tinymce-react that referenced this pull request May 29, 2025
tinymce#588 added an import from
@tinymce/miniature code in src/main/ts/Utils.ts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants